Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasets): verify file exists if on Polars 1.0 #957

Merged
merged 9 commits into from
Dec 6, 2024
Merged

fix(datasets): verify file exists if on Polars 1.0 #957

merged 9 commits into from
Dec 6, 2024

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Dec 5, 2024 •
edited
Loading

Description

Tests are not running with latest Polars

Development notes

Separated out Polars-related changes from #909. This should merge first.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@deepyaman
ci(datasets): unbound Polars for test requirements
5c0a1c9 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
test(datasets): use a more version-agnostic assert
3ca838a 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
revert(datasets): undo assert_frame_equal change
1ee7619 
Refs: 10af4db
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
chore(datasets): use the Polars 1.0 equality check
e1c4e3a 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
chore(datasets): use calamine engine in Polars 1.0
6b02296 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
revert(datasets): undo swap to the calamine engine
04e0a76 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
fix(datasets): raise error manually for Polars 1.0
c3b10d2 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman marked this pull request as ready for review December 5, 2024 18:13
astrojuanlu
astrojuanlu approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepyaman !

@deepyaman
ci(datasets): skip a failing doctest in Windows CI
44dda95 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman mentioned this pull request Dec 5, 2024
Merged
5 tasks
merelcht
merelcht approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@deepyaman
test(datasets): skip failing save tests on Windows
fc23bfa 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman merged commit 7baa826 into main Dec 6, 2024
12 of 13 checks passed
@deepyaman deepyaman deleted the test/datasets/polars-1.0 branch December 6, 2024 05:59
@deepyaman deepyaman mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @astrojuanlu @merelcht