Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring behavior on unsupported conversion #9

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

NQNStudios
Copy link
Contributor

Here you said:

I think this is fine as long as you don't need the value back (and obviously you don't because you just store it as null)
On the other hand I think a proper fix is to introduce some runtime metadata such that the conversion behaviour can be controlled by user code.

This was right--there are a lot of cases where you might want to suppress conversion errors. My other PR #8 is failing tests because of one of those.

So this PR reverts the special-case handling of the Lua class in #7 and instead introduces a variable that configures handling for every unsupported conversion.

@NQNStudios NQNStudios force-pushed the configure-throw branch 2 times, most recently from c279f44 to ce9ba4b Compare July 18, 2024 18:23
@kevinresol kevinresol merged commit 9168ead into kevinresol:master Jul 19, 2024
6 checks passed
@kevinresol
Copy link
Owner

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants