set error on the tag

khiga8 · Oct 5, 2023 · 6482958 · 6482958
1 parent bf1b34c
commit 6482958
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 14 deletions.
diff --git a/lib/md045.js b/lib/md045.js
@@ -5,6 +5,8 @@
 const { addError } = require("../helpers");
 const { filterByTypes, getHtmlTagInfo } = require("../helpers/micromark.cjs");
 
+const nextLinesRe = /[\r\n][\s\S]*$/;
+
 module.exports = {
   "names": [ "MD045", "no-alt-text" ],
   "description": "Images should have alternate text (alt text)",
@@ -33,13 +35,14 @@ module.exports = {
       if (htmlTagInfo && htmlTagInfo.name === "img") {
         const hasAltAttribute = new RegExp(/alt=/);
         if (!hasAltAttribute.test(token.text)) {
-          const range = (token.startLine === token.endLine) ?
-            [ token.startColumn, token.endColumn - token.startColumn ] :
-            undefined;
+          const range = [
+            token.startColumn,
+            token.text.replace(nextLinesRe, "").length
+          ];
           addError(
             onError,
             token.startLine,
-            undefined,
+            "Element: " + htmlTagInfo.name,
             undefined,
             range
           );

diff --git a/test/snapshots/markdownlint-test-scenarios.js.md b/test/snapshots/markdownlint-test-scenarios.js.md
@@ -13934,7 +13934,7 @@ Generated by [AVA](https://avajs.dev).
       errors: [
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             20,
             44,
@@ -18759,7 +18759,7 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             6,
             20,
@@ -33947,7 +33947,7 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             1,
             25,
@@ -33963,7 +33963,7 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             1,
             21,
@@ -33979,8 +33979,11 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
-          errorRange: null,
+          errorDetail: 'Element: img',
+          errorRange: [
+            1,
+            4,
+          ],
           fixInfo: null,
           lineNumber: 44,
           ruleDescription: 'Images should have alternate text (alt text)',
@@ -33992,8 +33995,11 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
-          errorRange: null,
+          errorDetail: 'Element: img',
+          errorRange: [
+            1,
+            4,
+          ],
           fixInfo: null,
           lineNumber: 48,
           ruleDescription: 'Images should have alternate text (alt text)',
@@ -37267,7 +37273,7 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             1,
             36,
@@ -38774,7 +38780,7 @@ Generated by [AVA](https://avajs.dev).
         },
         {
           errorContext: null,
-          errorDetail: null,
+          errorDetail: 'Element: img',
           errorRange: [
             1,
             52,

diff --git a/test/snapshots/markdownlint-test-scenarios.js.snap b/test/snapshots/markdownlint-test-scenarios.js.snap