Extract API implementations from Post Login API #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-wratt
force-pushed
the
extract-apis
branch
4 times, most recently
from
6cc1293 to
05345c5
Compare
matt-wratt
force-pushed
the
extract-apis
branch
2 times, most recently
from
f938640 to
c0535e7
Compare
matt-wratt
force-pushed
the
extract-apis
branch
2 times, most recently
from
4a63776 to
b4e1b3c
Compare
Aupajo
requested changes
Apr 11, 2024
examples/jsconfig.json
Outdated
| "compilerOptions": { | ||
| "moduleResolution": "nodenext" | ||
| } | ||
| } |
There was a problem hiding this comment.
This was in place to help type hinting (e.g. in VS Code). Have agreed to back this out as we're no longer depending on complicated TS exports.
| "/sandwich-preferences", | ||
| "Unexpected redirect URL path" | ||
| ); | ||
|
|
||
| // Test the signed JWT data payload | ||
| const { session_token } = redirect.queryParams; | ||
| const { session_token } = redirect.target.queryParams; |
There was a problem hiding this comment.
We'll revert this in the future (e.g. with a Proxy object) as this just creates an unnecessary property to have to type. See #19.
src/mock/api/rules.ts
Outdated
|
|
||
| const build = <T>(api: T) => ({ | ||
| wasExecuted: (ruleId: string) => { | ||
| return state.executed.includes(ruleId);; |
There was a problem hiding this comment.
Suggested change
| return state.executed.includes(ruleId);; | |
| return state.executed.includes(ruleId); |
src/mock/api/rules.ts
Outdated
| export function rulesMock(flow: string, { executedRules = [] }: { executedRules?: string[] } = {}) { | ||
| const state = { | ||
| executed: executedRules, | ||
| }; |
There was a problem hiding this comment.
Let's not put this in the state for now. It's only a value you can set in your preconditions. An Action can't modify this, so there will never be a need to test it in postconditions.
matt-wratt
force-pushed
the
extract-apis
branch
from
b4e1b3c to
cd2259e
Compare
matt-wratt
force-pushed
the
extract-apis
branch
from
cd2259e to
042fc6f
Compare
Aupajo
changed the title
Aupajo
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting point to DRY up API implementation so behaviour can be shared across flows.