Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous logs in actor.Interrupt #1273

Merged

Conversation

RebeccaMahany
Copy link
Contributor

Relates to #1205

A bunch of our rungroup actors log errors in their Interrupt functions that did not originate from them. This creates a lot of noise in the logs. Launcher already logs the originating error on exit:

{"caller":"locallogger.go:43","level":"debug","run service: fake error from signal notify":"run launcher","stack":"run service: fake error from signal notify","ts":"2023-08-01T16:44:11.189798Z"}
{"caller":"locallogger.go:43","level":"info","run service: fake error from signal notify":"run launcher","ts":"2023-08-01T16:44:11.189913Z"}

This PR removes all other extra instances of this log to make shutdown a little less noisy and a little easier to understand.

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wonder about the intent behind Interrupt(err error) as a signature.

@RebeccaMahany RebeccaMahany merged commit bb28ad8 into kolide:main Aug 1, 2023
@RebeccaMahany RebeccaMahany deleted the becca/log-rungroup-exit-err-once branch August 1, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants