add uptime to hostinfo checkup and tests #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Oct 11, 2023
zackattack01
commented
Oct 11, 2023
RebeccaMahany
approved these changes
Oct 11, 2023
directionless
approved these changes
Oct 11, 2023
| hc.data["uptime_friendly"] = formatUptime(uptimeRaw) | ||
| } | ||
|
|
||
| hc.data["uptime"] = uptimeRaw |
There was a problem hiding this comment.
Shouldn't this be inside that err == nil
There was a problem hiding this comment.
i assumed it would just be zero value and the friendly would show the error. I can leave unset in that case if you'd like
There was a problem hiding this comment.
I'm never really sure if the return is defined if there's an error. So my bias would be to drop it. (it should be zero, but...)
There was a problem hiding this comment.
yeah makes sense, adding to the follow up! thanks
| @@ -71,6 +82,34 @@ func hostName() string { | |||
| return hostname | |||
| } | |||
|
|
|||
| // formatUptime takes a raw uptime value in seconds | |||
| // and returns a human friendly relative time string | |||
| func formatUptime(uptime uint64) string { | |||
There was a problem hiding this comment.
Fancy! I'd take fractional days.
| tt := tt | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| if got := formatUptime(tt.uptime); got != tt.want { |
There was a problem hiding this comment.
This is fine, but we usually use expected and actual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds uptime to the Host Info checkup.
It will appear as informational output for doctor/flare as follows:
It will be logged within checkpoints as follows: