[LevelDB IndexedDB] Return empty rows instead of error when db or object store doesn't exist #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
previously approved these changes
Aug 12, 2024
zackattack01
approved these changes
Aug 12, 2024
RebeccaMahany
added
bug-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is more consistent behavior -- we already ignore filepaths that don't exist. If the filepath to the indexeddb exists, but the indexeddb hasn't been initialized (db doesn't exist yet, object store doesn't exist yet), we should also return no data instead of an error.