Clean up a couple places not yet using gowrapper #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
reviewed
Jan 7, 2025
| @@ -175,7 +175,9 @@ func (w *winSvc) Execute(args []string, r <-chan svc.ChangeRequest, changes chan | |||
| changes <- svc.Status{State: svc.Running, Accepts: cmdsAccepted} | |||
|
|
|||
| // Confirm that service configuration is up-to-date | |||
| go checkServiceConfiguration(w.slogger.Logger, w.opts) | |||
| gowrapper.Go(ctx, w.systemSlogger.Logger, func() { | |||
There was a problem hiding this comment.
🤞 🤞 trying not to get my hopes up lol
zackattack01
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple places that didn't match our
go funcpattern, so golangci-lint didn't catch them. Cleaning them up for now without adding a new golangci-lint rule.