Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added renovate config #4978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Dec 28, 2024

Description

  • Added renovate configuration. It automate dependency updates, quite similar to Dendabot, but it does provide more flebilities and support custom package updates.

Fixes #4973

Result on forked repo https://github.com/ik-workshop/external-dns-fork-renovate-bootstrap/pull/24/files

How to onboard

I'll share config how to onboard. Onboarding very similar to Dependabot as well.

Go to Github App

Screenshot 2024-12-28 at 12 37 36

Allow Renovate to access required repo. No credentials required

Screenshot 2024-12-28 at 12 38 36

Trust Renovate App

Screenshot 2024-12-28 at 12 38 47

You can access UI as well

Screenshot 2024-12-28 at 12 39 36

Check the logs of a recent job

Screenshot 2024-12-28 at 12 39 43

Regex used in config

Screenshot 2024-12-28 at 13 04 36

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ivankatliarchuk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@mloiseleur
Copy link
Contributor

mloiseleur commented Dec 30, 2024

That sound good to me.
Before I start reviewing this PR, @Raffo wdyt of this approach ? For the onboard, do you know if it's possible to use GitHub App on kubernetes-sigs ?

@Raffo
Copy link
Contributor

Raffo commented Dec 30, 2024

I don’t think we should proceed with this. We don’t have permissions to do changes like adding apps and I don’t see a lot of problems with dependabot. Updating the version docs like in the linked PR is really no hassle compared to what we have to pull off every time we do a release due to the constraints that the kubernetes flow imposes to us.

@ivankatliarchuk
Copy link
Contributor Author

So you would not consider renovate as a github action? I do get that there are multiple steps, and not all of them are simple. But step-by-step you could automate pretty much everything and make it quite safe at the same time too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants