-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): docs/flags.md generation #4983
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ivankatliarchuk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
That looks really interesting, thanks @ivankatliarchuk ! BTW, do you think you can connect on kubernetes slack to #external-dns channel ? |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
I would join k8s slack if i could ;-) 😂😂😂😂😂😂😂 |
Would you please add a |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Sure. Added. A note: Makefile contains quite few special characters that not necessary need to be there |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments.
I'd also ask that the folder name is adjusted as gen
is pretty generic and not descriptive of its content. Maybe you can have internernal/gen/flagdocs
or something similar to avoid long names? I'm open to other proposals as well.
code review changes Co-authored-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
added over Github UI, as Makefile contains some special characters
Changed folder name to |
code review Co-authored-by: Raffaele Di Fazio <raffo@github.com>
Description
Added logic to generate
docs/flags.md
file with all currently supported flags.At the moment, there are few way to find supported flags
--help
or similar--help
or similar--traefik-disable-legacy
ortraefik-disable-legacy=true
as well as where or not--no-
case is supported or not and what the default value isAdded tests that will fail if new flag is added and
docs/flag.md
not re-generatedFixes #4260
Checklist