Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump golang.org/x/net due to a vulncheck failure #1166

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 4, 2024

Fixes #N/A

Description

How was this change tested?

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from jmdeal and tallaxes April 4, 2024 00:13
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@engedaam engedaam force-pushed the bump-golang.org/x/net branch 2 times, most recently from d6ec81a to b22e19e Compare April 4, 2024 17:34
@engedaam engedaam marked this pull request as ready for review April 4, 2024 17:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jackfrancis April 4, 2024 17:34
go.mod Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the bump-golang.org/x/net branch from b22e19e to b1d8e58 Compare April 4, 2024 18:06
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@engedaam engedaam changed the title chore: Bump deps due to a vulncheck failure chore: Bump golang.org/x/net due to a vulncheck failure Apr 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d6de8b into kubernetes-sigs:main Apr 4, 2024
12 checks passed
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8559269803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 78.928%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 95.59%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 8529517078: -0.07%
Covered Lines: 8274
Relevant Lines: 10483

💛 - Coveralls

@engedaam engedaam deleted the bump-golang.org/x/net branch April 14, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants