-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Rendertron usage since it is deprecated #2911
Remove Rendertron usage since it is deprecated #2911
Conversation
Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an alternative to rendertron?
Good question @saschagrunert. I could not find a free and reliable tool to take screenshots online (without installing other dependencies). I found this screenshotmachine site that allows us to take 100 screenshots free per month but we need to create an account to get a token. Not sure if we have an org account for these types of services. |
I plan to update the doc and issue template to let people manually add testgrid status as of now before a replacement is in place. This PR at least will help in terms of generating testgrid status without throwing errors. Maybe the issue for finding/applying replacement of Rendertron? |
I've been a bit busy with work and KEP-1731, but I'm happy to pick this up again in near future. There are some things that I need to fix in #2783 but in general it works pretty well. |
Thanks for sharing! I have closed the issue since the work is planned and ongoing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward with this one and let #2783 provide a future replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/priority critical-urgent |
agree |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, palnabarun, ramrodo, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PRs removes Rendertron since it is deprecated.
With this removal, the
krel testgridshot
tool will no longer take screenshots of the TestGrid boards at adding the GitHub comment to the release cut issue. Also, it will no longer upload any screenshot to the GCS bucket.We need this removal since every time we run
krel testgridshot
and it tries to get the screenshot, the process fails and does not publish any GitHub comment throwing this error:This error has been mentioned a couple of times before at least, see:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?