Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: Build 1.24rc1 images #3872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 30, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.24rc1 images

/hold
/assign @ameukam @Verolop @puerco @MadhavJivrajani
cc @kubernetes/release-managers @liggitt

Which issue(s) this PR fixes:

xref #3772

Special notes for your reviewer:

Does this PR introduce a user-facing change?

golang: Build 1.24rc1 images

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2024
@cpanato cpanato mentioned this pull request Dec 30, 2024
29 tasks
@xmudrii
Copy link
Member

xmudrii commented Dec 30, 2024

This seems like a legitimate failure, but let's retest just in case.
/test pull-release-image-k8s-ci-builder

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, but let's see what's going on with the test.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Dec 30, 2024

the issue is

 > [builder 4/4] RUN ./compile-release-tools:
#6 0.079 Setting up environment...
#6 0.084 Compiling default release tools...
#6 0.086 fatal: not a git repository (or any of the parent directories): .git
#6 0.091 go: go.mod requires go >= 1.23.3 (running go 1.22.9; GOTOOLCHAIN=local)

will see how to fix that for k8s-ci-builder that runs go <= 1.22

@Verolop
Copy link
Contributor

Verolop commented Dec 30, 2024

/test pull-release-image-k8s-ci-builder

@k8s-ci-robot
Copy link
Contributor

@cpanato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-image-k8s-ci-builder 193f98d link true /test pull-release-image-k8s-ci-builder

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants