Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding SkFontMgr_New_Custom_Directory #292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HinTak
Copy link
Collaborator

@HinTak HinTak commented Dec 25, 2024

This pull is complete as is. I intend to pull this into m134, so no need for any immediate action.

The new API seems to be recursive - it scans subdirectories.

Fixes #291

@HinTak
Copy link
Collaborator Author

HinTak commented Dec 25, 2024

Github CI seems to have a regression - Intel mac os isn't able to get at the Apple Color Emoji font (arm mac os is successful) - it is failing at an unrelated test that passed at v132 a few weeks ago. I am just re-running the failed job. It is probably transient.

@HinTak
Copy link
Collaborator Author

HinTak commented Dec 25, 2024

Reproduced the failure with fork sync and identified the problematic image upgrade, so filed actions/runner-images#11241 for the CI failure.

Re-run failed job when upstream fixes that, I guess.

@HinTak
Copy link
Collaborator Author

HinTak commented Dec 27, 2024

There is a problem with mac os python 3.13.1 build at the moment - actions/runner-images#11241 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SkFontMgr_New_Custom_Directory
1 participant