Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add policy opentelemetry/inject-otel-environment-variable #1212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add policy opentelemetry/inject-otel-environment-variable #1212

wants to merge 3 commits into from

Conversation

babs
Copy link

@babs babs commented Dec 27, 2024

Description

This PR allow injection of opentelemetry environment variables based on namespace and pod annotations.

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

babs added 3 commits December 27, 2024 02:04
@babs
add policy opentelemetry/inject-otel-environment-variable
1fd174b 
Signed-off-by: Damien Degois <damien@degois.info>
@babs
set background to false
96b1ccf 
Signed-off-by: Damien Degois <damien@degois.info>
@babs
trigger only on Pod creation, not update
85fc548 
Signed-off-by: Damien Degois <damien@degois.info>
KhaledEmaraDev
KhaledEmaraDev approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@KhaledEmaraDev KhaledEmaraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it LGTM!

@eddycharly
Copy link
Member

It doesn't require any code change ?

@babs
Copy link
Author

babs commented Jan 3, 2025

For me it is stable as-is.
Some features could be added later on if needed.

@eddycharly
Copy link
Member

I didn't notice it was a PR on the policies repo 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhaledEmaraDev KhaledEmaraDev KhaledEmaraDev approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babs @eddycharly @KhaledEmaraDev