Change roleRef pattern to subjects #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will also need to update Artifact Hub metadata as well as test cases. |
* chore: add script to update artifacthub digest Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * script Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * install Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * install Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix digest Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> --------- Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
Changed the roleRef in patterns to subjects as the system groups are defined under subjects and not roleRef Signed-off-by: RanganMahesh <rangan502@gmail.com> Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
|
@chipzoller Please review now |
Recalculated SHA256 and updated Signed-off-by: RanganMahesh <rangan502@gmail.com> Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
|
@chipzoller Is there a way to generate the SHA256 sum differently ? It seems to be failing |
|
Just use |
Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
Signed-off-by: RanganMahesh <rangan502@gmail.com> Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
Signed-off-by: Rangan Mahesh <rangan502@gmail.com>
|
@chipzoller Rerun the pipelines |
|
@chipzoller Could you please help with this one ? Not sure why it is failing |
|
Checks successful. Was a transient failure. |
|
@chipzoller Great! |
|
@chipzoller good to merge? |
|
Sorry, will check this out again soon. |
chipzoller
approved these changes
Oct 10, 2023
|
@chipzoller Can we close the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the roleRef in patterns to subjects as the system groups are defined under subjects and not roleRef
Related Issue(s)
Fixes #777
Description
The updated code will make sure that the restrict-binding-system-groups example is applied and works on system groups, previously it was matching pattern for roleRef.
Checklist