feat: add other policies in CEL expressions - Part 6

[Chandan-DK]

Related Issue(s)

Partially addresses #891

Description

This PR includes the conversion of policies in the other folder to Kyverno CEL policies. Conversion of the policies is done in multiple PRs

Policies converted in this PR:

• restrict-loadbalancer
• restrict-networkpolicy-empty-podselector
• restrict-node-affinity
• restrict-sa-automount-sa-token
• restrict-secret-role-verbs
• restrict-secrets-by-name
• restrict-service-port-range
• restrict-storageclass
• restrict-usergroup-fsgroup-id
• restrict-wildcard-resources
• restrict-wildcard-verbs

Checklist

• [] I have read the policy contribution guidelines.
• [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
• [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

[MariamFahmy98]

Overall it looks good to me. I have just added a minor comment.

[MariamFahmy98]

@Chandan-DK - Could you please resolve the conflicts?

[Chandan-DK]

While resolving the merge conflict caused due to PR #1025, I realized that a Role and ClusterRole can be created by either omitting or keeping rules empty (https://github.com/kyverno/policies/pull/1025/files#diff-d8ebec1f6fac7038fbd1ecdea4d1797a84639e2fc96377af0537e5bc074fa200R1-R24). When it is created in this manner in the cluster, it will be set to rules: null by default. I've modified the policies to account for this behaviour and I've added for tests it.

[MariamFahmy98]

While resolving the merge conflict caused due to PR #1025, I realized that a Role and ClusterRole can be created by either omitting or keeping rules empty (https://github.com/kyverno/policies/pull/1025/files#diff-d8ebec1f6fac7038fbd1ecdea4d1797a84639e2fc96377af0537e5bc074fa200R1-R24). When it is created in this manner in the cluster, it will be set to rules: null by default. I've modified the policies to account for this behaviour and I've added for tests it.

Good catch.