use existing hooks instead of advice

laishulu · Dec 25, 2024 · cee7e94 · cee7e94
1 parent b83b8db
commit cee7e94
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/sis.el b/sis.el
@@ -645,7 +645,7 @@ TYPE: TYPE can be \\='native, \\='w32, \\='emp, \\='macism, \\='im-select,
 ;;
 ;; Following codes are mainly about cursor color mode
 ;;
-(defun sis--reset-default-cursor-color ()
+(defun sis--reset-default-cursor-color (&rest _)
     "Reset default cursor color to nil."
     (setq sis-default-cursor-color nil))
 
@@ -701,13 +701,15 @@ way."
     ;; auto refresh input source
     (unless (eq sis-external-ism 'native)
       (sis--try-enable-auto-refresh-mode))
-    (advice-add 'enable-theme :after #'sis--reset-default-cursor-color)
+    (add-hook 'enable-theme-functions #'sis--reset-default-cursor-color)
+    (add-hook 'disable-theme-functions #'sis--reset-default-cursor-color)
     (advice-add 'set-cursor-color :filter-args #'sis--set-cursor-color-advice)
     (add-hook 'sis-change-hook #'sis--update-cursor-color))
    (; turn off the mode
     (not sis-global-cursor-color-mode)
     (sis--try-disable-auto-refresh-mode)
-    (advice-remove 'enable-theme #'sis--reset-default-cursor-color)
+    (remove-hook 'enable-theme-functions #'sis--reset-default-cursor-color)
+    (remove-hook 'disable-theme-functions #'sis--reset-default-cursor-color)
     (advice-remove 'set-cursor-color #'sis--set-cursor-color-advice)
     (remove-hook 'sis-change-hook #'sis--update-cursor-color))))