Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing laminas-migration bin and autoload path #2

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Fix missing laminas-migration bin and autoload path #2

merged 4 commits into from
Oct 31, 2019

Conversation

arueckauer
Copy link
Member

Q A
Bugfix yes
BC Break no
New Feature no
RFC no

Description

Following the installation steps described here, the laminas-migration is not present in the global vendor/bin directory, due to a missing bin configuration in composer.json.

Secondly, invoking the laminas-migration command will fail due to an incorrect path to autoload.php.

This PR fixes both issues.

If desired, it is possible to change requiring the autoload file depending on whether the package was installed either as global or dev dependency.

@michalbundyra michalbundyra added the Bug Something isn't working label Oct 31, 2019
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

weierophinney added a commit that referenced this pull request Oct 31, 2019
@weierophinney weierophinney merged commit f407a3f into laminas:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants