Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Upgrade to lamindb 1.0 #927

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🚚 Upgrade to lamindb 1.0 #927

wants to merge 5 commits into from

Conversation

falexwolf
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jan 8, 2025

@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 15:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 17:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 8, 2025 17:26 Inactive
@Koncopd
Copy link
Member

Koncopd commented Jan 8, 2025

django 5 is not compatible with python 3.9

@falexwolf
Copy link
Member Author

falexwolf commented Jan 8, 2025

Yes, I studied this for the past 15 min 😅

Scientific Python is already beyond 3.10

image

EOL of Python 3.9 is in a few months

image

Hence my sense is that >3.10 should be OK, don't you think?

Reason is using Django's db_default without which we have problems in the hub backend.

@falexwolf falexwolf changed the title 🚚 Rename _accessor to otype 🚚 Upgrade to lamindb 1.0 Jan 8, 2025
@Koncopd
Copy link
Member

Koncopd commented Jan 8, 2025

But what are the problems? This sounds very suspicious to me.

@Koncopd
Copy link
Member

Koncopd commented Jan 8, 2025

I would prefer not to drop before EOL. This can definitely frustrate some users, we need to check first.

@falexwolf
Copy link
Member Author

This can definitely frustrate some users, we need to check first.

I know that a few users might not be happy about it. But I fear that without it, there is no lamindb 1.0 (I mean it'd be super hacky and ugly not to us db_default).

And without lamindb 1.0 we're practically dead-locked.

So, I'd accept that small nuisance given that we'll then be in a position of operating disruption free.

Do you see any other solution?

@Koncopd
Copy link
Member

Koncopd commented Jan 8, 2025

Why is db_default needed?

@falexwolf
Copy link
Member Author

Here is an important approval:

Why is db_default needed?

To declare defaults on the database level in a meaningful way. Several new fields error otherwise on the hub. And it should be declared on the database level anyway. So if we don't do it now, we have to do it in a year or so with the next migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants