Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use google's new sdk #11801

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: use google's new sdk #11801

wants to merge 8 commits into from

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Dec 18, 2024

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

sdk doc: https://googleapis.github.io/python-genai/ It support both gemini and vertex.
I already test basic chat, agent tools, multimodal files...
not work for json_schema now, wait the maintainer to resolve this. googleapis/python-genai#14

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@yihong0618
Copy link
Contributor

ci works !#11752

@hjlarry
Copy link
Contributor Author

hjlarry commented Dec 18, 2024

ci works !#11752

cool! seems require another PR to fix the CI

@yihong0618
Copy link
Contributor

ci works !#11752

cool! seems require another PR to fix the CI

Done can you take a look?

@hjlarry
Copy link
Contributor Author

hjlarry commented Dec 18, 2024

Done can you take a look?

Sure! It works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants