Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix session typo in workflow_trace method #12031

Merged

Conversation

You-keitou
Copy link
Contributor

@You-keitou You-keitou commented Dec 24, 2024

Summary

Fix typo in workflow_trace method where 'sessoin' was misspelled as 'session'. This fix enables proper workflow tracing functionality with langfuse integration.

Related to #12029 and addresses a typo found in #11954

Fix #12029

This simple typo fix should help resolve issues with workflow tracing and langfuse integration.

Screenshots

This is a typo fix that doesn't require visual changes to demonstrate.

Before After
N/A N/A

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@crazywoola crazywoola merged commit e0c24c0 into langgenius:main Dec 24, 2024
5 checks passed
@@ -360,7 +360,7 @@ def workflow_trace(self, workflow_run: WorkflowRun | None, conversation_id, user
raise ValueError("Workflow run not found")

db.session.merge(workflow_run)
db.sessoin.refresh(workflow_run)
db.session.refresh(workflow_run)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nich catch

@You-keitou You-keitou deleted the fix/workflow-trace-session-typo branch December 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot trace workflow execution due to session typo
3 participants