-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Several Exceptions in Workflow Usage #12075
Open
ndhjm
wants to merge
9
commits into
langgenius:main
Choose a base branch
from
AICT-Team:fix/backend-202412
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
🐞 bug
Something isn't working
💪 enhancement
New feature or request
labels
Dec 25, 2024
very clean Pull Request message learned that, thank you for the content |
yihong0618
reviewed
Dec 25, 2024
This reverts commit 2f0823d.
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Dec 27, 2024
I have standardized my code format and look forward to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
💪 enhancement
New feature or request
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve functionality, fix bugs, and enhance code readability. The most important changes include the addition of a new package in the Dockerfile, a fix for file name encoding in HTTP headers, and various bug fixes and improvements in the workflow nodes.
Resolves #12074
Improvements and Bug Fixes:
Dockerfile Update:
libreoffice
to the list of packages installed in the Dockerfile to support additional functionalities.File Name Encoding:
Content-Disposition
header to handle special characters properly by usingurllib.parse.quote
.Tool Parameter Type Fix:
ToolParameterType
class by changingsystme-files
tosystem-files
.Encoding Detection:
chardet
to detect file encoding dynamically when extracting text from CSV files, improving robustness against various encodings. [1] [2]Equality Check Fix:
_is
function to use==
instead ofis
for string comparison.This pull request includes several changes across multiple files to improve functionality and fix bugs. The most important changes include adding a new package to the Dockerfile, fixing a typo in an enum, enhancing file handling in the image preview controller, improving text extraction from CSV files, and updating the question classifier node to handle different query types.Improvements to Dockerfile:
libreoffice
installation to theDockerfile
to support additional functionalities.Bug Fixes:
ToolParameterType
enum from "systme-files" to "system-files"._is
function to use==
instead ofis
for string comparison inlist_operator/node.py
.Enhancements:
image_preview.py
controller by safely encoding filenames for theContent-Disposition
header.chardet
library. [1] [2]Updates to Question Classifier Node:
question_classifier_node.py
to handle different query types, including converting non-string types to JSON strings. [1] [2]This pull request includes several changes to theapi
module, focusing on enhancements, bug fixes, and improvements to the codebase. The most important changes include adding a new package to the Dockerfile, fixing a typo in an enumeration value, improving file handling in theimage_preview
controller, and updating text extraction and comparison logic.Enhancements:
api/Dockerfile
: Addedlibreoffice
to the list of packages installed during the Docker image build process.Bug fixes:
api/core/tools/entities/tool_entities.py
: Corrected a typo in theToolParameterType
enumeration value from "systme-files" to "system-files".api/controllers/files/image_preview.py
: Improved the handling of file names in theContent-Disposition
header by encoding the filename to ensure it is safely transmitted.Codebase improvements:
api/core/workflow/nodes/document_extractor/node.py
: Addedchardet
for detecting file encoding when extracting text from CSV files, enhancing the robustness of text extraction. [1] [2]api/core/workflow/nodes/list_operator/node.py
: Fixed the comparison logic in the_is
function to use==
instead ofis
, ensuring correct functionality.# SummaryPlease include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods