Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline characters in tables during document parsing #12112

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Hisir0909
Copy link
Contributor

Summary

This commit addresses an issue where newline characters within table cells were causing incorrect formatting and table misalignment during document parsing.

The fix ensures that newline characters within table cells are properly handled, allowing the table to maintain its intended structure and position in the parsed text. This improves the accuracy and readability of the parsed documents.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 26, 2024
@Hisir0909
Copy link
Contributor Author

Here are additions to this #11879

…tables-location' of github.com:Hisir0909/dify into fix-recognizing-line-breaks-in-extract-tables--and-fix-tables-location
@yihong0618
Copy link
Contributor

you can run the mypy in your local env.

cd api
(source env)
python -m mypy .

and need to install all the type package

mine is like this(use uv)

uv pip install  types-Flask-Cors types-Flask-Migrate types-PyYAML types-beautifulsoup4 types-openpyxl types-psycopg2 types-regex

@Hisir0909
Copy link
Contributor Author

you can run the mypy in your local env.

cd api (source env) python -m mypy .

and need to install all the type package

mine is like this(use uv)

uv pip install  types-Flask-Cors types-Flask-Migrate types-PyYAML types-beautifulsoup4 types-openpyxl types-psycopg2 types-regex

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants