Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #11920 api docker build #12124

Closed
wants to merge 1 commit into from

Conversation

kenwoodjw
Copy link
Contributor

@kenwoodjw kenwoodjw commented Dec 26, 2024

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #11920

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 26, 2024
@kurokobo
Copy link
Contributor

kurokobo commented Dec 26, 2024

To fix #11920, you should fix Makefile instead of entrypoint.sh.

See #5333 and #6946

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for changing flask upgrade-db into flask db upgrade.

flask upgrade-db command of commands.py is used here by design to gurarntee only one db migration is executed at the same time by acquring lock in Redis, or it would cause inconsistency and delusion in consequence. see #5333 for detailed purpose.

@kenwoodjw
Copy link
Contributor Author

To fix #11920, you should fix Makefile instead of entrypoint.sh.

See #5333 and #6946

Got it!

@kenwoodjw kenwoodjw closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask : upgrade-db
3 participants