feat: Auto-switch to authorized workspace when accessing URL #12131
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Comment on lines
+31
to
+36
| accessible_tenants = ( | ||
| db.session.query(Tenant) | ||
| .join(TenantAccountJoin, TenantAccountJoin.tenant_id == Tenant.id) | ||
| .filter(TenantAccountJoin.account_id == current_user.id) | ||
| .all() | ||
| ) |
There was a problem hiding this comment.
It's not the best way to check the user's accessiblilty of the targeted single tenant by loading all the tenants in to memory in one time. Try to use subquery or join to ensure that and minimize the momory footprints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user story:
Our product managers usually share prototype URLs to each other. They usually don’t understand the program or dify product logic, so we need to guide them to switch workspaces. I made a small optimization to automatically switch workspaces if there is permission.
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods