Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Postgres user name in docker-compose.yaml #12139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regnull
Copy link

@regnull regnull commented Dec 26, 2024

Summary

Connection errors were generated when I ran docker compose locally (cannot connect as user postgres)

The Postgres docker doc clearly states that the user name should be POSTGRES_USER:

https://hub.docker.com/_/postgres

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 26, 2024
@regnull regnull changed the title Update docker-compose.yaml Fix Postgres user name in docker-compose.yaml Dec 26, 2024
bowenliang123

This comment was marked as outdated.

@yihong0618
Copy link
Contributor

yihong0618 commented Dec 27, 2024

did it maybe break old user's database?

@bowenliang123
Copy link
Contributor

bowenliang123 commented Dec 27, 2024

did it maybe break old user's database?

I don't think so. There's concret evidence that POSTGRES_USER is being used for long in PG 15 docker image for long.
see: https://github.com/docker-library/postgres/blob/master/15/bookworm/docker-entrypoint.sh#L92

@kurokobo
Copy link
Contributor

Related to: #9888 (comment)

@laipz8200
Copy link
Member

# ==================================================================
# WARNING: This file is auto-generated by generate_docker_compose
# Do not modify this file directly. Instead, update the .env.example
# or docker-compose-template.yaml and regenerate this file.
# ==================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants