Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avatar dropdown keyboard navigation #12155

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

douxc
Copy link
Contributor

@douxc douxc commented Dec 27, 2024

Summary

we can navigation through avatar dropdown menu items using the keyboard

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@douxc douxc marked this pull request as ready for review December 27, 2024 08:07
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 27, 2024
@iamjoel iamjoel self-requested a review December 27, 2024 08:12
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 27, 2024
@douxc douxc merged commit 89ce9a5 into main Dec 27, 2024
7 checks passed
@douxc douxc deleted the fix/avatar-dropdown-keyboard-navigation branch December 27, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants