Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inputs variables value changed but not work on Chatflow App #12160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

liuzhenghua
Copy link
Contributor

Summary

This PR enables the Chatflow app to change the values of variables in inputs with each message sent.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

image
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 27, 2024
@liuzhenghua
Copy link
Contributor Author

you can use a simple workflow which contains a code node to test it.
image

@crazywoola
Copy link
Member

Please see this as well #10652

@liuzhenghua
Copy link
Contributor Author

Please see this as well #10652

I think it's not very reasonable to directly read the user's inputs every time. For example, some variables are only set at the beginning of the conversation, and there’s no need to pass them around later. So, my code checks if the inputs are empty, and if so, it continues to use the session's inputs.

@liuzhenghua
Copy link
Contributor Author

I think modifying variables only makes sense in the Chatflow App. For a simple chat assistant, variables can only be placed in the prompt, specifically in system-type messages. Once the conversation has started, changing them doesn't have much significance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants