Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12193
This pull request introduces support for a new vector type, ELASTICSEARCH_JA, which includes changes across various files to integrate this new functionality. The most important changes include adding the new vector type to the existing system, implementing the necessary configurations, and modifying the Docker setup to support the new vector type.
Integration of new vector type ELASTICSEARCH_JA:
api/controllers/console/datasets/datasets.py
: AddedVectorType.ELASTICSEARCH_JA
to the list of supported vector types.api/core/rag/datasource/vdb/vector_type.py
: AddedELASTICSEARCH_JA
to theVectorType
class.api/core/rag/datasource/vdb/vector_factory.py
: Added a case forVectorType.ELASTICSEARCH_JA
to return the ElasticSearchJaVectorFactory.api/core/rag/datasource/vdb/elasticsearch/elasticsearch_ja_vector.py
: Created a new file to defineElasticSearchJaConfig
,ElasticSearchJaVector
, andElasticSearchJaVectorFactory
classes, providing the implementation for the new vector type.Configuration and setup changes:
docker/.env.example
: Updated the supported values forVECTOR_STORE
and modified theELASTICSEARCH_HOST
default value.docker/docker-compose.yaml
: Added theelasticsearch-ja
profile, updated the elasticsearch service configuration to include the new profile, and added resource limits andentrypoint
configurations.docker/elasticsearch/docker-entrypoint.sh
: Created a new script to install necessary plugins forelasticsearch-ja
and run the original entrypoint script.Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods