Add support for proxying multiple domains at once #1437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for proxying multiple domains at once with a comma separated list of domains, such as
valet proxy my-domain,sub.my-domain http://127.0.0.1:8000
The change is backwards compatible, since I explode the URL by comma, if there's no comma present it works as before.
Reason for this change is working locally with Octane can be a bit frustrating. We have an app that uses multiple domains and we use Valet to proxy those domains to Octane. However, currently we'd have to run these commands:
This not only takes a long time, Valet also restarts nginx after each command, prompting for the sudo password every time.
With this change it can be done in a single command, is much faster and only restarts nginx once;
It also includes the
unproxy
commandAnd this will also work if you proxied
domain,api.domain
and then runvalet unproxy api.domain
, as it will only unproxy theapi.domain
and keep thedomain
proxy