ci: allow revert PRs #1740
ci: allow revert PRs #1740
Conversation
|
.commitlintrc
Outdated
| "extends": ["@commitlint/config-conventional"] | ||
| "extends": ["@commitlint/config-conventional"], | ||
| "ignores": [ | ||
| (commit) => commit.startsWith("Revert ") |
There was a problem hiding this comment.
this looks like JS - should we rename the file to clarify and get better IDE integration?
my preference would be commitlint.config.ts (https://github.com/conventional-changelog/commitlint#config)
There was a problem hiding this comment.
Yes, I can do that. Are there any other changes I need to make?
There was a problem hiding this comment.
Hi, I'm unable to import the types needed for this action. Do you have any idea why?
There was a problem hiding this comment.
@holic I would truly appreciate some help here.
There was a problem hiding this comment.
have you installed @commitlint/types as a new dependency?
There was a problem hiding this comment.
Hi @alvrs, when I tried to install the dependency before, I encountered an error message that went something like pnpm.ps1 cannot be loaded because running scripts is disabled on this system. For more information, see.... I switched to a different IDE, and now I get an entirely different message. Am I not supposed to install the dependency in the root folder?
There was a problem hiding this comment.
I got it to work. Please review the changes.
| @@ -1683,6 +1687,13 @@ packages: | |||
| prettier: 2.8.4 | |||
| dev: true | |||
|
|
|||
| /@commitlint/types@17.4.4: | |||
There was a problem hiding this comment.
looks like this got added to the lockfile but not to package.json
did you use pnpm add to add this? try pnpm add -D -w @commitlint/types
There was a problem hiding this comment.
@holic I did use pnpm add. I ran the command, and it updated the lock file, but there were no changes in the package.json :( Am I missing something?
holic
changed the title
|
weird, I updated the PR title but wasn't able to get this to pass with the new config I dug in a bit more and looks like the default rules should already ignore revert messages of this shape: |
|
Looks like this is specifically related to the CI action we use to validate PR titles, not commitlint config: |
|
Going to close this for now as I think this requires some upstream fixes or replacing our CI step with another approach. Thanks for the attempt! Feel free to open another PR if you want to take another stab at this using a different approach. |
|
@holic I understand, no problem. |
Fixes #1486
Update PR linter to ignore commit messages beginning with
Revert