ci: pin typescript dependency to 5.6.3 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Dec 4, 2024
| @@ -42,7 +42,7 @@ runs: | |||
| - name: Build JS API | |||
| shell: bash | |||
| run: | | |||
| cd api-js && npm install && npx publint | |||
| cd api-js && npm install && npx publint && npx --yes @arethetypeswrong/cli --pack . | |||
There was a problem hiding this comment.
Also adding another linting step that checks a bunch of Typescript typing stuff.
cwaldren-ld
changed the title
kinyoklion
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary measure to restore CI builds for the JS API. It appears that the release related to microsoft/TypeScript#60019 surfaced an issue in the way we're importing JSON files into the SDK. Despite it being a minor release, it was a breaking change for us.
But, I can't actually seem to fix it at the moment. Hopefully a subsequent release will allow us to do so. I'm not 100% following the conversation but it looks like a fix will be cherrypicked to Typescript 5.7: microsoft/TypeScript#60673