This repository has been archived by the owner on May 18, 2019. It is now read-only.
Add LEGO logo to studs #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user now has the possibility to select an option that puts the LEGO logo on top off all studs in the file. A requirement for this is that the "logo3.dat" file from the LDraw parts tracker is located in the standard p folder. Note that I also changed the threshold for the cleanup, because otherwise the logo would loose its geometry because it's so small. To make sure the thershold is fit for all import scales, the threshold is now multiplied by the import scale.
|
I've almost got my laptop back, so I'll try to look at this as soon as I can. :) |
|
I've been getting pretty good-looking results with normal maps, but the thing is that it isn't very evident how to implement it in the code because of the UV map needed. It's something I'll have to look into, but I have the impression that normal maps are the way to go to keep the files manageable. Thoughts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user now has the possibility to select an option that puts the LEGO logo on top off all studs in the file. A requirement for this is that the "logo3.dat" file from the LDraw parts tracker is located in the standard p folder.
We still have to figure out the best way to deal with this logo3.dat file. I imagine it's better to just store it somewhere with the script, instead of messing with the users LDraw libraries.
Also, some kind of warning would be nice, because this option tends to slow down the import process a lot because for each part, the logo file has to be read. For this reason especially, it would be great to only import each file once in the beginning and then reference the data.
Finally, I didn't really do anything to ensure the logo's face the right direction. I thought I read somewhere they should be defined right, but in unofficial parts that could not be the case. The question is if errors would be very noticeable.
PS: I'm currently modelling a new logo.dat file that represents the logo's with a mold mark in them for added realism. Would be fun to include this as well, although then it will become hard to judge which stud to assing the mold mark to...