Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number-box) #1019

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(number-box) #1019

wants to merge 6 commits into from

Conversation

c0nstexpr
Copy link

@c0nstexpr c0nstexpr commented Mar 26, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature

What is the current behavior?

Fix NumberBox functionality. Now ValueProperty will update after lost focus and correct the TextProperty

Issue Number: #1016

What is the new behavior?

ValueProperty will only be updated after losting focus.

Other information

Remove some unused code.

@c0nstexpr c0nstexpr requested a review from pomianowski as a code owner March 26, 2024 09:18
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet labels Mar 26, 2024
@c0nstexpr
Copy link
Author

Updated, fix compile errors and remove my own test code

@textGamex

This comment was marked as resolved.

@pomianowski pomianowski deleted the branch lepoco:main July 26, 2024 12:02
@pomianowski pomianowski reopened this Jul 26, 2024
@pomianowski pomianowski changed the base branch from development to main July 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants