feat: braavos x strk farm nft

[Marchand-Nicolas]

Summary by CodeRabbit

• New Features

  • The call-to-action button in the Quest Banner now only appears when a valid CTA is provided.

• Style Changes

  • Enhanced layout and responsiveness of the Quest Banner with new aspect-ratio properties for images.
  • Removed margin-top from the Quest Banner title for improved design consistency.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sepolia-starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 8:18am
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 8:18am

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/quests/questBanner.tsx

Oops! Something went wrong! :(

ESLint: 9.17.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces modifications to the QuestBanner component in components/quests/questBanner.tsx and the corresponding CSS styles in styles/quests.module.css. The changes focus on improving the rendering logic of the quest banner by conditionally rendering the call-to-action (CTA) button and adjusting the image aspect ratio for better responsiveness.

Changes

File	Change Summary
components/quests/questBanner.tsx	Modified CTA button rendering to only display when banner.cta is truthy
styles/quests.module.css	Added aspect-ratio: 1/1; to .questBannerImage class, removed margin-top from .questBannerTitle, and set aspect-ratio: unset; in media query for screens ≤ 740px

Possibly related issues

• Update components/quests/questBanner.tsx to no longer use JSON #986: This issue directly aligns with the PR's changes, proposing to refactor QuestBanner to use a banner object passed as a prop instead of relying on a JSON file, which matches the modifications in the current pull request.

Possibly related PRs

• feat: braavos x strkfarm quest #1000: Appears to contain identical changes to the current pull request, suggesting a closely related or potentially duplicate modification to the quest banner component and its styles.

Suggested reviewers

• fricoben

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

components/quests/questBanner.tsx (1)

25-35: Consider adding rel="noopener noreferrer" for security.

When using target="_blank", it's good practice to include rel="noopener noreferrer" to alleviate security concerns related to the new tab having access to the window.opener object.

<Button
  onClick={() => {
-    window.open(banner.href, "_blank");
+    window.open(banner.href, "_blank", "noopener,noreferrer");
  }}
>
  {banner.cta}
</Button>

styles/quests.module.css (1)

346-346: Ensure aspect ratio property meets cross-browser support requirements.

aspect-ratio is well-supported in modern browsers but might require fallbacks for older browsers. Consider double-checking analytics or adding fallback styles if necessary.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23e0474 and 3d6126e.

📒 Files selected for processing (2)

• components/quests/questBanner.tsx (1 hunks)
• styles/quests.module.css (2 hunks)

🔇 Additional comments (1)

styles/quests.module.css (1)

444-444: Responsive design approach is consistent.

Unsetting aspect-ratio at smaller screen sizes allows flexible scaling of images, ensuring a better user experience on narrow screens.

[fricoben]

lgtm