Fix variable name from string catalog with an acronym in the name #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Strings Catalog contained an uppercase acronym at the start, the variable name generated would incorrectly only lowercase the first character.
For example:
URLStrings.xcstrings would generate a struct called
URLStrings
as expected, but the variable/label would beuRLStrings
which is not expected.In this PR, I update the logic so that we lowercase the n-1 initial characters if more than 1 character is uppercased at the start of the string.
This means that the example above will generate a variable named
urlStrings