Set save redirect paths before set_environment #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeOsborn
pushed a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
savefile_directoryin override file by moving redirect set before environment setRETRO_ENVIRONMENT_GET_SAVE_DIRECTORYlogging, and renamed toSAVE_DIRECTORYlikeSYSTEM_DIRECTORYWithout this change the path changing does work with
--appendconfig, but not with overrides, even though overrides are parsed right after appends in the same manner.So is there a better way, or can this cause other problems? Sure feels like the current order is clearly wrong in any case, and this seems fine as far as I can tell. What harm could there be for the core to get the final paths as early as possible..?
libretro.hdoes not explicitly say one way or the other, but makes sense to me that those paths are ready to be fetched already inretro_set_environment()and not later inretro_load_game(), since the paths are environment vars after all.