Pointer sanitization - x11, udev #17281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the sanitized pointer handling, discussed at libretro#17196 : X11 driver specific changes: make sure pointer position is always within [-0x7fff,0x7fff] by using the confined wrapper remove extra "inside" checks, general simplification enable pointer offscreen reporting Udev driver specific changes: remove custom calculation and use common viewport translation unify pointer query instead of separate _x and _y enable pointer offscreen reporting Other changes: more tuning of pointer conversion in video_driver.c for edges lightgun button ID conversion moved to input_driver.c
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Adapt the sanitized pointer handling, discussed at libretro#17196 : X11 driver specific changes: make sure pointer position is always within [-0x7fff,0x7fff] by using the confined wrapper remove extra "inside" checks, general simplification enable pointer offscreen reporting Udev driver specific changes: remove custom calculation and use common viewport translation unify pointer query instead of separate _x and _y enable pointer offscreen reporting Other changes: more tuning of pointer conversion in video_driver.c for edges lightgun button ID conversion moved to input_driver.c
|
This PR create a bad behaviour with mayflash and wiimotes issue raised #17338 pls can you take a look into it? thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt the sanitized pointer handling, discussed at #17196 :
X11 driver specific changes:
Udev driver specific changes:
Other changes:
Tests done: remote retropad in an X11 desktop (x11, udev), fullscreen/windowed, mouse grab/no grab, pointer/lightgun combinations, and also in KMS mode (udev). Reporting off-window events could be probably refined a bit (on Wayland it is more smooth), but this PR does not change the behavior in that respect.
Related Pull Requests
#17169
#17169 (comment)