Overlay lightgun fixes #17340
Merged
Overlay lightgun fixes #17340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neil4
commented
Jan 3, 2025
neil4
commented
- Fix the "Allow Off-Screen" setting not working since Pointer sanitization: Android, overlay, and other enhancements #17308
- Fix offscreen shot disabling the overlay lightgun on some cores
- Fullscreen pointer coordinates no longer needed
- Fix the "Allow Off-Screen" setting not working since libretro#17308 - Prevent offscreen shot from disabling the lightgun with some cores - Fullscreen pointer coordinates no longer needed
|
Hi @neil4 , thank you for checking. Can you mention in which situations (core, content, usecase etc.) is disabling the "allow off-screen" option useful? As mentioned in #17308, most input drivers will now behave in the "enabled" mode, and I am wondering if there is some variation I have not thought of. |
|
Having an "allow off-screen" option just makes edge aiming easier when off-screen shots aren't needed, which is common if not the norm. IMO, it would be a good option for lightguns in general, not just the overlay. |
|
Ach so, makes sense. Noted, I have some idea about how to handle it generally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.