Add option to disable shaders and overlay when taking GPU screenshots - Issue #10537 #17349
+123
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght be useful to have as an option?
Fixed bug where shader option was forcibly set to on.
Changed method of disabling shaders Fixed shaders/overlay not being re-enabled if screenshot failed Made the new options Advanced options
…el/RetroArch into gpu_screenshot_noshader
… and/or overlay support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
This pull requests adds 2 additional options on the menu below GPU Screenshot named 'GPU Screenshot Shaders' with sublabel 'Include shaders when taking GPU Screenshot' and 'GPU Screenshot Overlay' with sublabel 'Include overlays when taking GPU Screenshot'. The default values for these options is ON which preserves the current behavior. They're also only visible if Advanced Options is set to ON.
Why? Some cores are hardware rendered only so the only screenshot taken is a GPU screenshot, so when using shaders and/or overlays these will be included as part of the screenshot which might not be desirable. When these new options are set to OFF, shaders and/or overlays will be disabled before the screenshot is taken and re-enabled after.
I'm making this a draft pull request as I want feedback/guidance on the nomenclature of the options on code and their naming and description as visible to the user. Should they instead be named 'Exclude Shaders from GPU Screenshot' and set the default value to OFF? Should the word 'include/exclude' be part of the option name itself?
This is the current presentation as seen with Ozone
Related Issues
#10537
Related Pull Requests
[Any other PRs from related repositories that might be needed for this pull request to work]
Reviewers
[If possible @mention all the people that should review your pull request]