Skip to content

Commit

Permalink
iwpmd: fix double mutex unlock
Browse files Browse the repository at this point in the history 
pthread_mutex_unlock() is used twice and this patch fixes it.

Fixes: be3fbf8 ("iwpmd: use ccan list.h for pending_messages")
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
  • Loading branch information
@bharatpotnuri @dledford
bharatpotnuri authored and dledford committed Jan 31, 2018
1 parent 654b270 commit c7f4e44
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion iwpmd/iwarp_pm_helper.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg *send_msg)

pthread_mutex_lock(&pending_msg_mutex);
list_add(&pending_messages, &pending_msg->entry);
pthread_mutex_unlock(&pending_msg_mutex);
pthread_mutex_unlock(&pending_msg_mutex);
/* signal the thread that a new message has been posted */
pthread_cond_signal(&cond_pending_msg);
Expand Down

3 comments on commit c7f4e44

@dledford
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmorey Please cherry pick this back to both stable branches, and @larrystevenwise would like a point update release so this library with this fix can be pulled by the OFA into OFED.

@nmorey
Copy link
Contributor

@nmorey nmorey commented on c7f4e44 Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dledford Checking that all is working and will release later today with this fix and the broadcom ones from PR #288

@dledford
Copy link
Contributor

@dledford dledford commented on c7f4e44 Feb 2, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.