Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add lsiobase #59

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix/add lsiobase #59

merged 2 commits into from
Oct 7, 2024

Conversation

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:e22e560b-pkg-e22e560b-dev-e221fb8f3f1af6a402ad30b26ce235dfbc126177-pr-59

@GilbN GilbN requested review from aptalca and thespad October 2, 2024 19:06
@aptalca
Copy link
Member

aptalca commented Oct 7, 2024

This PR looks good, but it reminded me that we should move away from passing lsiobase/alpine or lsiodev/blah as the IMAGE value to the ci container. This is something we'll have to change in the jenkins builder, but we also need to make the ci container ready for it.

We also have a draft PR: linuxserver/docker-jenkins-builder#183 which would move everything from lsiobase, lsiodev and lspipepr orgs on docker hub to the main linuxserver org, and the image names will be consistent with the ghcr naming scheme (ie. linuxserver/baseimage-alpine, linuxserver/lsiodev-blah and linuxserver/lspipepr-blah).
We prepared that PR when docker hub initiated pull limits and our ci builds were failing, but we were able to solve the issue another way. So the PR is still pending, but with a lower priority.

Just a heads up

@GilbN
Copy link
Member Author

GilbN commented Oct 7, 2024

Yup, CI container should handle it just fine.

@GilbN GilbN merged commit 0f11971 into master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants