-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uploading large files #481
base: develop
Are you sure you want to change the base?
Conversation
As per the nextcloud documentation, this should not be done as it can break low memory systems; user should read the documentation, understand the risks, and update accordingly. The default we use is the recommended official default from nextcloud. |
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
Note that some of the defaults you're proposing here are significantly higher than the values NC's own documentation provides as examples for increasing the values. |
Yup, I don't see a downside, the real limits are user quotas and disk space |
If we're confident that there are no concerns with lower resource devices then I'm ok with these changes. Main reason we stuck with what is in NC's docs is because the thought was that lower powered devices might not love the higher limits. |
I've tested it on a container with a 512mb ram limit and everything still works fine, even uploading huge files. |
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Fix uploading large files which is a very common support issue