-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add specific compilation rule for sql.c #352
Open
devin-ai-integration
wants to merge
32
commits into
main
Choose a base branch
from
devin/1734661596-fix-sql-makefile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced SQL query validation in sql.c with whitelist approach - Added dangerous token detection for SQL injection prevention - Improved overwrite.c to use safe SQL queries - Added comprehensive SQL injection prevention tests - Updated Makefile to include SQL injection test target Security: Fixes #29 Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
…on prevention Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
…quirements Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
…ions Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
…ndency Co-Authored-By: Matt Wong <matt@liquidaty.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Devin is currently unreachable - the session may have died. |
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Co-Authored-By: Matt Wong <matt@liquidaty.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specific compilation rule for sql.c to handle its sql_internal.h dependency.
Fixes the build failures in #351 by adding a dedicated Makefile rule for sql.c compilation.
Link to Devin run: https://app.devin.ai/sessions/7bc67faddc4d4c96ad62208b48c20218