Added backend changes for stop experiment #4227
Conversation
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
| if experiment.CronSyntax != "" { | ||
|
|
||
| err = c.DisableCronExperiment(username, experiment, projectID, r) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| } |
There was a problem hiding this comment.
I can see the use case where users might want to temporarily suspend all ongoing runs but any future runs should still happen. We should give the user the option to explicitly disable the future runs imo instead of disabling by default.
There was a problem hiding this comment.
@gdsoumya This case is handled in the backend, so if a user sends a both experimentID and experimentRunID, only the current run will be stopped. but if experimentRunID is nil, it will stop all the running experiment and disable the cron if present. However, in future we are planning to add one more API to just enable/disable the cron.
There was a problem hiding this comment.
I think then in the future when the cron specific endpoint is introduced the behavior of this endpoint should be changed so that it doesn't stop the cron imo
There was a problem hiding this comment.
yes, will remove this one with the addition of cron API
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
There was a problem hiding this comment.
I think the call to the actual StopExperimentRuns is missing here?
There was a problem hiding this comment.
Yes it was in WIP, have added the implementation.
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
yes @namkyu1999 |
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: