Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Eliminate Global Variable to Enhance Testability #4997

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

andoriyaprashant
Copy link
Contributor

@andoriyaprashant andoriyaprashant commented Dec 17, 2024

Fixes #4217

Proposed changes

This pull request refactors the codebase by removing a global variable to improve testability.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@andoriyaprashant andoriyaprashant force-pushed the 1branch branch 2 times, most recently from 5092e5e to 1c83e62 Compare December 17, 2024 06:29
Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image you have to update the mocks and the unit tests as well. the checks are failing here

andoriyaprashant and others added 13 commits December 26, 2024 20:36
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Sayan Mondal <sayan.mondal@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…muschaos#4992)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…litmuschaos#4957)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: namkyu1999 <lak9348@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Björn Kylberg <47784470+bjoky@users.noreply.github.com>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Kursat Aktas <kursat.ce@gmail.com>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.23.0 to 0.31.0.
- [Commits](golang/crypto@v0.23.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…#5002)

* updated go mod in auth and gql

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated go mod in auth and gql

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…ifest (litmuschaos#4881)

Signed-off-by: Rogério Brito <rogeriobritoufu@gmail.com>
Co-authored-by: Sayan Mondal <sayan.mondal@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove global variable for better unit testing
8 participants