-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Eliminate Global Variable to Enhance Testability #4997
Open
andoriyaprashant
wants to merge
14
commits into
litmuschaos:master
Choose a base branch
from
andoriyaprashant:1branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andoriyaprashant
force-pushed
the
1branch
branch
2 times, most recently
from
December 17, 2024 06:29
5092e5e
to
1c83e62
Compare
Saranya-jena
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Sayan Mondal <sayan.mondal@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: DongYoung Kim <kwx4957@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…muschaos#4992) Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…litmuschaos#4957) Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: namkyu1999 <lak9348@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Björn Kylberg <47784470+bjoky@users.noreply.github.com> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Kursat Aktas <kursat.ce@gmail.com> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.23.0 to 0.31.0. - [Commits](golang/crypto@v0.23.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…#5002) * updated go mod in auth and gql Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated go mod in auth and gql Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…ifest (litmuschaos#4881) Signed-off-by: Rogério Brito <rogeriobritoufu@gmail.com> Co-authored-by: Sayan Mondal <sayan.mondal@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
force-pushed
the
1branch
branch
from
December 26, 2024 15:06
5a4685d
to
09c1fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4217
Proposed changes
This pull request refactors the codebase by removing a global variable to improve testability.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.