-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11.x Compatibility #48
Conversation
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-search-string.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"lorisleiva/laravel-search-string": "dev-l11-compatibility",
}
} Finally, run: |
@lorisleiva would you mind taking a look at this PR to add Laravel 11 support? Thanks! 🙏 |
Hi there, I'm afraid this is a lot more problematic than anticipated. The HOA compiler that this uses has been abandoned for a while now and while it worked brilliantly all these years, new PHP syntax seem to have made that package unusable. Changing the compiler would be a huge undertaking that I'm not willing to tackle at this point so, unless someone is able to save this package by submitting a PR that swaps the compiler for another implementation, this package will stay as-is for the foreseeable future. |
@lorisleiva Would you accept a PR with this fork? https://github.com/hiqdev/hoa-compiler |
Yeah that'd be great! I'm assuming that's the exact same compiler but with the latest PHP versions? |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:
l11-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.