Fix LoadProhibited when using SoftwareSerial in a funky way. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I ran into a slight initialization issue when when running ZE27-O3 in my project:
I narrowed it down to the
setStream()call entering the wrong case (as if HW serial was used when in actuality it was SW serial) and performing an invalid load (most likely a null-ish pointer dereference). It was a pretty easy fix - just initializing the HW and SW internal variables to nullptr so that we make sure only the right one is non-null. Tested it with both ZE25 and ZE27 libs (looks like it's the same code really 🤷).Haven't changed the other sensors setup.