Add option to disable examples apps #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimage1
reviewed
Mar 20, 2024
CMakeLists.txt
Outdated
| add_subdirectory(${LWIP_DIR}/contrib/ports/win32/example_app) | ||
| elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} STREQUAL "Darwin") | ||
| add_subdirectory(${LWIP_DIR}/contrib/ports/unix/example_app) | ||
| OPTION(LWIP_OPTION_ENABLE_EXAMPLE_APPS "Build example apps on win32/unix/darwin" ON) |
There was a problem hiding this comment.
should be win32/linux/darwin not win32/unix/darwin, since unix is used for both Linux and Darwin.
There was a problem hiding this comment.
@DmitriiKostrov fixed in latest commit.
There was a problem hiding this comment.
@DmitriiKostrov Is there anything else that needs done to get this in? Been sitting 2 weeks now with no action.
There was a problem hiding this comment.
Hi, all looks fine for me. But I'm not a maintainer and cannot fully aprove it. Sorry
dimage1
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone wants the example apps built on these platforms. For our specific use case we have an emulated build for tests and target platform is embedded, in the test environment we don't actually want real sockets. This PR adds an option to disable the example app builds for those that don't want it. The default is to retain the current behavior of building them by default on these platforms.